• DieguiTux8623@feddit.it
    link
    fedilink
    arrow-up
    0
    ·
    1 year ago

    The worst case is when someone requires changes, you address them, but then they disappear/go on a leave.

    If the repository rules require all conversations to be resolved before merging and only the original reviewer can mark them as solved, the PR is stuck forever even if the rest of the team approves it.

  • Cheesebaron@feddit.dk
    link
    fedilink
    arrow-up
    0
    ·
    1 year ago

    This always happens to me when I’ve written some genius code. Takes so long to review it, because my caveman colleagues don’t understand it.

  • pimeys@lemmy.nauk.io
    link
    fedilink
    arrow-up
    0
    ·
    1 year ago

    A 15000 line PR landing on a Friday evening for the lucky random reviewer to open on Monday. “Please approve it fast so we avoid too many conflicts.”