• Sethayy@sh.itjust.works
      link
      fedilink
      English
      arrow-up
      0
      ·
      4 months ago

      Yeah but they don’t have to be visible to every process the user runs, my Minecraft mods really don’t need access to my encryption keys

  • punkcoder@lemmy.world
    link
    fedilink
    English
    arrow-up
    0
    ·
    4 months ago

    I think the issue that they are trying to make is that there are modern ways of protecting the keys with hardware level security, that aren’t being used. As someone who works in AppSec this is all too common. All it takes is one library in an application to be popped (doesn’t have to be signal), and security keys end up leaked. If it isn’t already, I’m sure that signals keys will be included in exfil scripts.

    Tools like TPM and SecureEnclaves (TrustZone,etc) mean that malware, and other nasties have a higher bar that they need to meet.

    • douglasg14b@programming.dev
      link
      fedilink
      English
      arrow-up
      0
      ·
      4 months ago

      Yeah, and electron already has a secureStorage API that handles the OS interop for you. Which signal isn’t using, and a PR already exists to enable…

      • punkcoder@lemmy.world
        link
        fedilink
        English
        arrow-up
        0
        ·
        4 months ago

        I’m not surprised… I think people (‘the ones that care at least’) would be horrified to know how much of this stuff slips through, because it’s hard (there are so many other things that are pulling at developers that something falls through the cracks). Most of the time the right answer is to bring it up. Then thank them when they resolve the issue (with beer and pizza money at the very least).

        Looks like it’s waiting for approval, https://github.com/signalapp/Signal-Desktop/pull/6933 for anyone else thats interested.

  • uhh_matt@sh.itjust.works
    link
    fedilink
    English
    arrow-up
    0
    ·
    4 months ago

    Ah yes, the old “your data isn’t safe when an attacker has full access to your pc account” vulnerability

      • BearOfaTime@lemm.ee
        link
        fedilink
        English
        arrow-up
        0
        ·
        edit-2
        4 months ago

        Exactly, which is why your drives should be encrypted.

        Once you lose physical control of a device, all bets are off, drive encryption at least slows down attackers significantly.

        I have far more sensitive, and a greater volume of data, on the drive than just comms.

        • Sethayy@sh.itjust.works
          link
          fedilink
          English
          arrow-up
          0
          ·
          edit-2
          4 months ago

          Drive encryption wouldn’t do anything to mitigate this though? A process running on your PC needs access to your drive, and so with the current setup you have either the option to trust 100% every software with your signal encryption keys, or to simply not use them.

          Seems like a pretty big security flaw that we have actual solutions to.

          You could maybe form a hackey way to allow only the signal process to an encrypted FUSE filesystem that decrypts its own keys on the fly, but again there’s already ways to do this in software that isn’t like using a wrench to plug a leak. (and this setup would just have it’s own set of keys that need to be protected now, probably by a traditional method like kwallet)

    • douglasg14b@programming.dev
      link
      fedilink
      English
      arrow-up
      0
      ·
      4 months ago

      Not necessarily. There are many paths to exfiltrated data that don’t require privileged access, and can be exploited through vulnerabilities in other applications.